Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#1755 flush testing logger on terminate #1831

Merged
merged 4 commits into from
Apr 18, 2023
Merged

iox-#1755 flush testing logger on terminate #1831

merged 4 commits into from
Apr 18, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 20, 2022 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

This PR adds some functionality to the testing logger to flush the caches log messages on std::terminate, SIGSEV and SIGFPE.

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-1755-flush-testing-logger-on-terminate branch from 79e3665 to ceb0e88 Compare December 20, 2022 15:34
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

Merging #1831 (29d60be) into master (207d419) will decrease coverage by 0.53%.
The diff coverage is n/a.

❗ Current head 29d60be differs from pull request most recent head 4523a08. Consider uploading reports for the commit 4523a08 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   75.51%   74.99%   -0.53%     
==========================================
  Files         388      383       -5     
  Lines       15276    14692     -584     
  Branches     2158     2099      -59     
==========================================
- Hits        11536    11018     -518     
+ Misses       3067     3030      -37     
+ Partials      673      644      -29
Flag Coverage Δ
unittests 74.65% <ø> (-0.52%) ⬇️
unittests_timing 15.28% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 235 files with indirect coverage changes

@elBoberido elBoberido self-assigned this Feb 6, 2023
@elBoberido elBoberido added test A module/integration/stress/etc test for a component tooling All iceoryx related tooling (scripts etc.) labels Feb 6, 2023
@elBoberido elBoberido force-pushed the iox-1755-flush-testing-logger-on-terminate branch 3 times, most recently from b325b09 to 29d60be Compare February 6, 2023 21:52
@elBoberido elBoberido force-pushed the iox-1755-flush-testing-logger-on-terminate branch from 29d60be to 436db65 Compare April 3, 2023 18:18
@elBoberido elBoberido marked this pull request as ready for review April 4, 2023 11:51
@elBoberido elBoberido requested review from dkroenke and elfenpiff April 4, 2023 11:51
@elBoberido elBoberido changed the title WIP iox-#1755 flush testing logger on terminate iox-#1755 flush testing logger on terminate Apr 4, 2023
FerdinandSpitzschnueffler
FerdinandSpitzschnueffler previously approved these changes Apr 13, 2023
View reviewed changes
iceoryx_hoofs/testing/testing_logger.cpp Outdated Show resolved Hide resolved
@elBoberido elBoberido merged commit 0cdf9ed into eclipse-iceoryx:master Apr 18, 2023
@elBoberido elBoberido deleted the iox-1755-flush-testing-logger-on-terminate branch April 18, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler FerdinandSpitzschnueffler approved these changes

@elfenpiff elfenpiff elfenpiff approved these changes

@dkroenke dkroenke Awaiting requested review from dkroenke

Assignees

@elBoberido elBoberido

Labels
test A module/integration/stress/etc test for a component tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elBoberido @elfenpiff @FerdinandSpitzschnueffler